Skip to content

chore: Stop using Livechat_Room_Count setting#35017

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
chore/remove-setting
Jan 23, 2025
Merged

chore: Stop using Livechat_Room_Count setting#35017
kodiakhq[bot] merged 3 commits intodevelopfrom
chore/remove-setting

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 23, 2025 •
edited
Loading

Proposed changes (including videos or screenshots)

Setting was not being used anywhere, we can safely remove.

Thought on using it for metrics, but it's generally easier a count on the collection with the estimatedDocumentCount we have right now than to keep track of this value.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-930

Steps to test or reproduce

Further comments

Ok, maybe we're not removing here entirely, but the point is to stop using it. There's another task for the migration to remove it.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 23, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: aa3a6a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added this to the 7.4.0 milestone Jan 23, 2025
@codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (9100cec) to head (aa3a6a8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35017      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68118    68117       -1     
  Branches     15145    15145              
===========================================
- Hits         40312    40311       -1     
  Misses       24975    24975              
  Partials      2831     2831
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35017/

Built to branch gh-pages at 2025-01-23 20:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@KevLehman KevLehman marked this pull request as ready for review January 23, 2025 16:41
@KevLehman KevLehman requested review from a team as code owners January 23, 2025 16:41
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 23, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 23, 2025
MarcosSpessatto
MarcosSpessatto suggested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to create a task to create a migration to a major version? So we can remove the setting?

@KevLehman
Copy link
Member Author

KevLehman commented Jan 23, 2025

Yup, I'm creating the other task to remove the setting. This one will just stop using it (as we're updating it for no reason everytime a new Omni room is created)

@KevLehman KevLehman changed the title chore: Remove Livechat_Room_Count setting chore: Stop using Livechat_Room_Count setting Jan 23, 2025
@kodiakhq kodiakhq bot merged commit 9d9e3a2 into develop Jan 23, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-setting branch January 23, 2025 20:59
juliajforesti pushed a commit that referenced this pull request Jan 28, 2025
@KevLehman @juliajforesti
chore: Stop using Livechat_Room_Count setting (#35017)
8ec486c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

+2 more reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@tapiarafael tapiarafael tapiarafael approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@KevLehman @MarcosSpessatto @tapiarafael @MartinSchoeler